Sample CI Cleanup #637
Open
Sample CI Cleanup #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
reviewed
Aug 27, 2025
| @@ -11,10 +11,6 @@ | |||
| { | |||
| "name": "--message", | |||
| "data": "hello" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Verify that we're actually running this sample because last I remember, greengrass IPC samples in CI was broken
There was a problem hiding this comment.
Verified that we are running the sample and test. It was added in this PR: #585
and is used in the CI job linux-greengrass-tests. It's currently setup to run the sample basic_discovery.py which unfortunately used the MQTT3 client. I'm hoping in the next full samples pass to be able to convert it to MQTT5 but I'm not immediately familiar enough with the test to off-hand know if it's possible. If it's not, I'll probably move the sample out of the the samples folder into a testing folder to remove all traces of MQTT3 from the main samples folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.